From be3a169b0cb7b749fc5eaee887ef2f6ed2d60ee2 Mon Sep 17 00:00:00 2001 From: Kaleb Elwert Date: Wed, 16 Oct 2019 10:42:43 -0700 Subject: [PATCH] Fix TestSignals to remove a possible race --- session_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/session_test.go b/session_test.go index f086792..9d3cc50 100644 --- a/session_test.go +++ b/session_test.go @@ -291,7 +291,9 @@ func TestSignals(t *testing.T) { session, _, cleanup := newTestSession(t, &Server{ Handler: func(s Session) { - signals := make(chan Signal) + // We need to use a buffered channel here, otherwise it's possible for the + // second call to Signal to get discarded. + signals := make(chan Signal, 2) s.Signals(signals) if sig := <-signals; sig != SIGINT { t.Fatalf("expected signal %v but got %v", SIGINT, sig)