CI: Implement gosec

.github/workflows/go.yml

@@ -1,4 +1,4 @@
-name: Go
+name: Vibe Check
 
 on:
   push:
@@ -7,19 +7,18 @@ on:
     branches: [ master ]
 
 jobs:
-
   build:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
           go-version: 1.18
-
-      - name: Build
-        run: go build -v ./...
-
-      - name: Vet
+      - name: go vet -v ./...
         run: go vet -v ./...
+      - name: gosec ./...
+        uses: securego/gosec@master
+          args: ./...
+      - name: go build -v ./...
+        run: go build -v ./...

cmd/HellPot/HellPot.go

@@ -34,7 +34,7 @@ func main() {
 	signal.Notify(stopChan, syscall.SIGINT, syscall.SIGTERM)
 
 	go func() {
-		log.Error().Err(http.Serve()).Msg("HTTP err")
+		log.Error().Err(http.Serve()).Msg("HTTP error")
 	}()
 
 	<-stopChan // wait for SIGINT

config/logger.go

@@ -32,7 +32,7 @@ func StartLogger() zerolog.Logger {
 
 	if snek.GetBool("logger.use_date_filename") {
 		tn := strings.ReplaceAll(time.Now().Format(time.RFC822), " ", "_")
-		tn = strings.ReplaceAll(logFileName, ":", "-")
+		tn = strings.ReplaceAll(tn, ":", "-")
 		logFileName = logFileName + "_" + tn
 	}
 

extra/decorate.go

@@ -21,7 +21,6 @@ func bannerFail(errs ...error) {
 func Banner() {
 	if runtime.GOOS == "windows" || config.NoColor {
 		println(config.Title + " " + config.Version)
-		println(" ")
 		return
 	}
 	PrintBanner()