From e210c70e211c04347e8587cf49ad2ac919e72f54 Mon Sep 17 00:00:00 2001
From: mgabdev <>
Date: Wed, 3 Jul 2019 23:47:23 -0400
Subject: [PATCH] Removed visiblity favorites of a status

todo: remove account ids from returning in "favourited_by"
---
 .../gabsocial/components/status_action_bar.js |  2 +-
 .../status/components/detailed_status.js      | 27 ++++++-------------
 app/javascript/gabsocial/features/ui/index.js |  3 ---
 3 files changed, 9 insertions(+), 23 deletions(-)

diff --git a/app/javascript/gabsocial/components/status_action_bar.js b/app/javascript/gabsocial/components/status_action_bar.js
index fc3f0157..bd677581 100644
--- a/app/javascript/gabsocial/components/status_action_bar.js
+++ b/app/javascript/gabsocial/components/status_action_bar.js
@@ -262,7 +262,7 @@ class StatusActionBar extends ImmutablePureComponent {
         </div>
         <div className='status__action-bar__counter'>
           <IconButton className='status__action-bar-button star-icon' animate active={status.get('favourited')} pressed={status.get('favourited')} title={intl.formatMessage(messages.favourite)} icon='star' onClick={this.handleFavouriteClick} />
-          {favoriteCount !== 0 && <Link to={`/${status.getIn(['account', 'acct'])}/posts/${status.get('id')}/favorites`} className='detailed-status__link'>{favoriteCount}</Link>}
+          {favoriteCount !== 0 && <span className='detailed-status__link'>{favoriteCount}</span>}
         </div>
         {shareButton}
 
diff --git a/app/javascript/gabsocial/features/status/components/detailed_status.js b/app/javascript/gabsocial/features/status/components/detailed_status.js
index 24e48861..9d171cc9 100644
--- a/app/javascript/gabsocial/features/status/components/detailed_status.js
+++ b/app/javascript/gabsocial/features/status/components/detailed_status.js
@@ -168,25 +168,14 @@ export default class DetailedStatus extends ImmutablePureComponent {
       );
     }
 
-    if (this.context.router) {
-      favouriteLink = (
-        <Link to={`/${status.getIn(['account', 'acct'])}/posts/${status.get('id')}/favorites`} className='detailed-status__link'>
-          <Icon id='star' />
-          <span className='detailed-status__favorites'>
-            <FormattedNumber value={status.get('favourites_count')} />
-          </span>
-        </Link>
-      );
-    } else {
-      favouriteLink = (
-        <a href={`/interact/${status.get('id')}?type=favourite`} className='detailed-status__link' onClick={this.handleModalLink}>
-          <Icon id='star' />
-          <span className='detailed-status__favorites'>
-            <FormattedNumber value={status.get('favourites_count')} />
-          </span>
-        </a>
-      );
-    }
+    favouriteLink = (
+      <span className='detailed-status__link'>
+        <Icon id='star' />
+        <span className='detailed-status__favorites'>
+          <FormattedNumber value={status.get('favourites_count')} />
+        </span>
+      </span>
+    );
 
     return (
       <div style={outerStyle}>
diff --git a/app/javascript/gabsocial/features/ui/index.js b/app/javascript/gabsocial/features/ui/index.js
index ae6b58fa..ffc678bd 100644
--- a/app/javascript/gabsocial/features/ui/index.js
+++ b/app/javascript/gabsocial/features/ui/index.js
@@ -232,9 +232,6 @@ class SwitchingColumnsArea extends React.PureComponent {
         <Redirect     from='/@:username/posts/:statusId/reblogs' to='/:username/posts/:statusId/reblogs' />
         <WrappedRoute path='/:username/posts/:statusId/reblogs' layout={LAYOUT.STATUS} component={Reblogs} content={children} />
 
-        <Redirect     from='/@:username/posts/:statusId/favorites' to='/:username/posts/:statusId/favorites' />
-        <WrappedRoute path='/:username/posts/:statusId/favorites' layout={LAYOUT.STATUS} component={Favourites} content={children} />
-
         <WrappedRoute layout={LAYOUT.EMPTY} component={GenericNotFound} content={children} />
       </Switch>
     );