From 20f634713cf18d94aa9d5b344b195d48b30bc95e Mon Sep 17 00:00:00 2001 From: Micooz Date: Sat, 16 Jun 2018 22:20:19 +0800 Subject: [PATCH] proxies: fix a vulnerability in log output --- src/proxies/socks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proxies/socks.js b/src/proxies/socks.js index 704059d..1d1f456 100644 --- a/src/proxies/socks.js +++ b/src/proxies/socks.js @@ -355,7 +355,7 @@ export function createServer({ bindAddress, bindPort, username, password }) { // Username/Password Authentication if (isAuthRequired) { if (username !== request.username || password !== request.password) { - logger.error(`[socks] [${appAddress}] invalid socks5 authorization, username=${request.username} password=${request.password}`); + logger.error(`[socks] [${appAddress}] invalid socks5 authorization username/password, dump=${dumpHex(buffer)}`); socket.end(Buffer.from([SOCKS_VERSION_V5, 0x01])); return; }