sad/raptorq
1
0
Fork 0
mirror of https://github.com/cberner/raptorq.git synced 2024-06-27 09:19:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace retain() with position() + swap_remove()

Browse Source 
This improves performance by 1-2%
This commit is contained in:
Christopher Berner 2021-02-03 20:53:49 -08:00
parent 5e506b5b78
commit 67a90ede4e
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/pi_solver.rs
View File

@ -128,7 +128,9 @@ impl FirstPhaseRowSelectionStats {
// Recompute all stored statistics for the given row
pub fn recompute_row<T: BinaryMatrix>(&mut self, row: usize, matrix: &T) {
let ones = matrix.count_ones(row, self.start_col, self.end_col);
self.rows_with_single_one.retain(|x| *x != row);
if let Some(index) = self.rows_with_single_one.iter().position(|x| *x == row) {
self.rows_with_single_one.swap_remove(index);
}
if ones == 1 {
self.rows_with_single_one.push(row);
}
@ -167,7 +169,9 @@ impl FirstPhaseRowSelectionStats {
self.ones_per_row.decrement(row);
let ones = self.ones_per_row.get(row);
if ones == 0 {
self.rows_with_single_one.retain(|x| *x != row);
if let Some(index) = self.rows_with_single_one.iter().position(|x| *x == row) {
self.rows_with_single_one.swap_remove(index);
}
} else if ones == 1 {
self.remove_graph_edge(row, matrix);
}
@ -181,7 +185,9 @@ impl FirstPhaseRowSelectionStats {
self.ones_per_row.decrement(row);
let ones = self.ones_per_row.get(row);
if ones == 0 {
self.rows_with_single_one.retain(|x| *x != row);
if let Some(index) = self.rows_with_single_one.iter().position(|x| *x == row) {
self.rows_with_single_one.swap_remove(index);
}
} else if ones == 1 {
self.rows_with_single_one.push(row);
self.remove_graph_edge(row, matrix);
@ -201,7 +207,9 @@ impl FirstPhaseRowSelectionStats {
self.ones_per_row.decrement(row);
let ones = self.ones_per_row.get(row);
if ones == 0 {
self.rows_with_single_one.retain(|x| *x != row);
if let Some(index) = self.rows_with_single_one.iter().position(|x| *x == row) {
self.rows_with_single_one.swap_remove(index);
}
} else if ones == 1 {
self.rows_with_single_one.push(row);
self.remove_graph_edge(row, matrix);