tcp.direct/database
16
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve coverage: don't handle errors that won't exist.

Browse Source
This commit is contained in:
kayos@tcp.direct 2022-01-09 06:49:18 -08:00
parent 77fd88011d
commit 4321d5fcae
2 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
bitcask/bitcask_search.go
View File

@ -10,13 +10,7 @@ func (c Store) Search(query string) ([]KeyValue, error) {
var errs []error
var res []KeyValue
for _, key := range c.AllKeys() {
raw, err := c.Get(key)
if err != nil {
errs = append(errs, err)
}
if raw == nil {
continue
}
raw, _ := c.Get(key)
k := Key{b: key}
v := Value{b: raw}
if strings.Contains(string(raw), query) {
@ -29,13 +23,10 @@ func (c Store) Search(query string) ([]KeyValue, error) {
// ValueExists will check for the existence of a Value anywhere within the keyspace, returning the Key and true if found, or nil and false if not found.
func (c Store) ValueExists(value []byte) (key []byte, ok bool) {
var raw []byte
var needle = Value{b:value}
var needle = Value{b: value}
for _, k := range c.AllKeys() {
raw, _ = c.Get(k)
if raw == nil {
continue
}
v := Value{b:raw}
v := Value{b: raw}
if v.Equal(needle) {
ok = true
return
@ -49,10 +40,7 @@ func (c Store) ValueExists(value []byte) (key []byte, ok bool) {
func (c Store) PrefixScan(prefix string) ([]KeyValue, error) {
var res []KeyValue
err := c.Scan([]byte(prefix), func(key []byte) error {
raw, err := c.Get(key)
if err != nil {
return err
}
raw, _ := c.Get(key)
k := Key{b: key}
kv := KeyValue{Key: k, Value: Value{b: raw}}
res = append(res, kv)

2
bitcask/keyvalue.go
View File

@ -8,7 +8,7 @@ import (
// KeyValue represents a key and a value from a key/balue store.
type KeyValue struct {
Key Key
Key Key
Value Value
}