kayos
/
girc-atomic
1
1
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Improve tests

This commit is contained in:
kayos@tcp.direct 2022-10-23 01:56:01 -07:00
parent 3458ae3d6d
commit d91de1c3c0
Signed by: kayos
GPG Key ID: 4B841471B4BEE979
4 changed files with 46 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
client_test.go
View File

@ -93,14 +93,24 @@ func TestClientLifetime(t *testing.T) {
func TestClientUptime(t *testing.T) {
c, conn, server := genMockConn()
defer conn.Close()
defer server.Close()
defer func() {
if err := conn.Close(); err != nil {
t.Errorf("failed to close connection: %s", err)
}
if err := server.Close(); err != nil {
t.Errorf("failed to close server: %s", err)
}
}()
go mockReadBuffer(conn)
done := make(chan struct{}, 1)
c.Handlers.Add(INITIALIZED, func(c *Client, e Event) { close(done) })
go c.MockConnect(server)
go func() {
if err := c.MockConnect(server); err != nil {
t.Errorf("failed to connect: %s", err)
}
}()
defer c.Close()
select {
@ -138,14 +148,24 @@ func TestClientUptime(t *testing.T) {
func TestClientGet(t *testing.T) {
c, conn, server := genMockConn()
defer conn.Close()
defer server.Close()
defer func() {
if err := conn.Close(); err != nil {
t.Errorf("failed to close connection: %s", err)
}
if err := server.Close(); err != nil {
t.Errorf("failed to close server: %s", err)
}
}()
go mockReadBuffer(conn)
done := make(chan struct{}, 1)
c.Handlers.Add(INITIALIZED, func(c *Client, e Event) { close(done) })
go c.MockConnect(server)
go func() {
if err := c.MockConnect(server); err != nil {
t.Errorf("failed to connect: %s", err)
}
}()
defer c.Close()
select {
@ -169,8 +189,14 @@ func TestClientGet(t *testing.T) {
func TestClientClose(t *testing.T) {
c, conn, server := genMockConn()
defer server.Close()
defer conn.Close()
defer func() {
if err := conn.Close(); err != nil {
t.Errorf("failed to close connection: %s", err)
}
if err := server.Close(); err != nil {
t.Errorf("failed to close server: %s", err)
}
}()
go mockReadBuffer(conn)
errchan := make(chan error, 1)

3
event_test.go
View File

@ -111,7 +111,7 @@ func TestParseEvent(t *testing.T) {
}
if got == nil {
t.Errorf("ParseEvent: got nil, want: %s", tt.want)
t.Fatalf("ParseEvent: got nil, want: %s", tt.want)
}
if got.String() != tt.want {
@ -133,6 +133,7 @@ func TestParseEvent(t *testing.T) {
}
}
//goland:noinspection GoNilness
func TestEventCopy(t *testing.T) {
var nilEvent *Event

4
example_test.go
View File

@ -59,7 +59,7 @@ func Example_simple() {
client.Handlers.Add(girc.PRIVMSG, func(c *girc.Client, e girc.Event) {
if strings.Contains(e.Last(), "hello") {
c.Cmd.ReplyTo(e, "hello world!")
_ = c.Cmd.ReplyTo(e, "hello world!")
return
}
@ -99,7 +99,7 @@ func Example_commands() {
client.Handlers.Add(girc.PRIVMSG, func(c *girc.Client, e girc.Event) {
if strings.HasPrefix(e.Last(), "!hello") {
c.Cmd.ReplyTo(e, girc.Fmt("{b}hello{b} {blue}world{c}!"))
_ = c.Cmd.ReplyTo(e, girc.Fmt("{b}hello{b} {blue}world{c}!"))
return
}

12
state_test.go
View File

@ -136,12 +136,12 @@ func TestState(t *testing.T) {
}
adm := ch.Admins(c)
admList := []string{}
var admList []string
for i := 0; i < len(adm); i++ {
admList = append(admList, adm[i].Nick)
}
trusted := ch.Trusted(c)
trustedList := []string{}
var trustedList []string
for i := 0; i < len(trusted); i++ {
trustedList = append(trustedList, trusted[i].Nick)
}
@ -250,7 +250,9 @@ func TestState(t *testing.T) {
bounceStart <- true
})
conn.SetDeadline(time.Now().Add(5 * time.Second))
if err := conn.SetDeadline(time.Now().Add(5 * time.Second)); err != nil {
t.Fatal(err)
}
_, err := conn.Write([]byte(mockConnStartState))
if err != nil {
panic(err)
@ -316,7 +318,9 @@ func TestState(t *testing.T) {
bounceEnd <- true
})
conn.SetDeadline(time.Now().Add(5 * time.Second))
if err = conn.SetDeadline(time.Now().Add(5 * time.Second)); err != nil {
t.Fatal(err)
}
_, err = conn.Write([]byte(mockConnEndState))
if err != nil {
panic(err)